fix(ui): open the repo's page from the repo list, Repo box and ★ By repo #119

deadstyle · 2026-10-10T07:25:49-05:00

deadstyle commented

2026-10-10 07:25:49 -05:00

Summary

o did nothing wherever the selection was a repo itself. It now opens the repo's page from the repo list, the Repo box (box level and README tab), and ★ Renovate By repo rows. On the Branches and Files tabs o still opens only the cursor entry, and nothing when there isn't one. o open now shows in the repo-list hints.

Refs #117

Verification

Reproduced on the Forgejo host in a sandboxed terminal: PR/issue/run links reached the system opener; repo rows produced nothing.
New tests (TestOpenRepoPage, TestRepoListHintsOpenOnlyOnARepo) fail on develop and pass here.
make check: format and lint clean (0 issues.), go test -race ./... ok across all packages, govulncheck "No vulnerabilities found", build ok, scripts/test-install.sh PASS, vet-windows ok. shellcheck isn't installed locally (fails the same way on develop); this diff touches no shell, so CI covers it.

Review

Spec: PASS.
Standards: PASS. Dismissed: "no test for empty Branches/Files fallback" (covered by the existing TestBranchesUnavailableOnHost and TestFilesOpenIsDisabledInEmptyDirectory); the shape note about repo-list dispatch sitting beside openTarget (kept small on purpose).
Comments: one restating doc comment on starOpenTarget, fixed.

Docs

design.md keymap row for o records the PM's answer (repo list opens the repo page). architecture.md and ADRs: nothing to update.

🤖 Generated with Claude Code

https://claude.ai/code/session_011V1QHxdTA8cs6mwLNYyVNf

## Summary `o` did nothing wherever the selection was a repo itself. It now opens the repo's page from the repo list, the Repo box (box level and README tab), and ★ Renovate By repo rows. On the Branches and Files tabs `o` still opens only the cursor entry, and nothing when there isn't one. `o open` now shows in the repo-list hints. Refs #117 ## Verification - Reproduced on the Forgejo host in a sandboxed terminal: PR/issue/run links reached the system opener; repo rows produced nothing. - New tests (`TestOpenRepoPage`, `TestRepoListHintsOpenOnlyOnARepo`) fail on develop and pass here. - `make check`: format and lint clean (`0 issues.`), `go test -race ./...` ok across all packages, govulncheck "No vulnerabilities found", build ok, `scripts/test-install.sh` PASS, `vet-windows` ok. `shellcheck` isn't installed locally (fails the same way on develop); this diff touches no shell, so CI covers it. ## Review - Spec: PASS. - Standards: PASS. Dismissed: "no test for empty Branches/Files fallback" (covered by the existing `TestBranchesUnavailableOnHost` and `TestFilesOpenIsDisabledInEmptyDirectory`); the shape note about repo-list dispatch sitting beside `openTarget` (kept small on purpose). - Comments: one restating doc comment on `starOpenTarget`, fixed. ## Docs design.md keymap row for `o` records the PM's answer (repo list opens the repo page). architecture.md and ADRs: nothing to update. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_011V1QHxdTA8cs6mwLNYyVNf

deadstyle added 2 commits

2026-10-10 07:25:49 -05:00

fix(ui): open the repo's page from the repo list, Repo box and ★ By repo 003c90bdc4

o did nothing wherever the selection was a repo itself, because the
open-target lookup had no case for a repo. The Branches and Files tabs
still open only their cursor entry.

Refs #117

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011V1QHxdTA8cs6mwLNYyVNf

docs(ui): say why the By repo row needs its own open target

ci / check (pull_request) Failing after 1m3s

Details

606d06448b

Refs #117

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011V1QHxdTA8cs6mwLNYyVNf

deadstyle added 1 commit

2026-10-10 07:28:09 -05:00

test(ui): drop o from the Repo box no-op keys now that it opens the repo

ci / check (pull_request) Successful in 1m19s

Details

575af19363

The old case passed locally only because it launched a real browser.

Refs #117

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011V1QHxdTA8cs6mwLNYyVNf

deadstyle merged commit c46cd74ae8 into develop

2026-10-10 07:31:28 -05:00

deadstyle deleted branch bugfix/117-open-repo

2026-10-10 07:31:28 -05:00

deadstyle referenced this pull request

2026-10-10 07:31:28 -05:00

o does nothing on the repo list, Repo box and ★ By repo rows #117

deadstyle referenced this pull request from a commit

2026-10-10 07:31:28 -05:00

fix(ui): open the repo's page from the repo list, Repo box and ★ By repo (#119)

Sign in to join this conversation.

No reviewers