Config: TOML config and state, token resolution, host selection #5

New issue

deadstyle · 2026-10-01T21:55:16-05:00

deadstyle commented

2026-10-01 21:55:16 -05:00

Problem

lazyforge needs to know which forge to talk to and how to sign in, and it has to save that as TOML. This ticket is the config layer. The onboarding, Settings and host-picker screens on top of it moved to #24.

Plan

internal/config: load and save config.toml and state.toml as described in ADR 0004 (atomic writes; 0600 and a permission check whenever a pasted token is stored; XDG paths). Validation errors name the field.
Token resolution: run token_cmd through sh -c with a timeout, or use the stored token. Tokens are never logged and never appear in error strings.
Merge-gating setting: "only merge when CI is green", per host with a per-repo override, off by default (PM decision, #13). Config shape: require_green_ci on the host, plus a per-repo override table.
Host selection: --host, then the only configured host, then default_host, otherwise report that the picker is needed (#24 builds it). --config <path> overrides the config location.

Depends on

#4 (merged).

Context

ADR 0004 (TOML, no database, token handling), docs/architecture.md → "Configuration and stored state".
go-development → I/O, context and secrets. The TOML dependency (BurntSushi/toml) is already approved in ADR 0004.

Out of scope

OS keyring storage (later). All screens (#24).

## Problem lazyforge needs to know which forge to talk to and how to sign in, and it has to save that as TOML. This ticket is the config layer. The onboarding, Settings and host-picker screens on top of it moved to #24. ## Plan 1. **`internal/config`:** load and save `config.toml` and `state.toml` as described in ADR 0004 (atomic writes; `0600` and a permission check whenever a pasted token is stored; XDG paths). Validation errors name the field. 2. **Token resolution:** run `token_cmd` through `sh -c` with a timeout, or use the stored `token`. Tokens are never logged and never appear in error strings. 3. **Merge-gating setting:** "only merge when CI is green", per host with a per-repo override, off by default (PM decision, #13). Config shape: `require_green_ci` on the host, plus a per-repo override table. 4. **Host selection:** `--host`, then the only configured host, then `default_host`, otherwise report that the picker is needed (#24 builds it). `--config <path>` overrides the config location. ## Depends on #4 (merged). ## Context - ADR 0004 (TOML, no database, token handling), `docs/architecture.md` → "Configuration and stored state". - `go-development` → I/O, context and secrets. The TOML dependency (`BurntSushi/toml`) is already approved in ADR 0004. ## Out of scope OS keyring storage (later). All screens (#24).

deadstyle added the

feature

sonnet

labels

2026-10-01 21:55:24 -05:00

deadstyle changed title from ~~Config file, token_cmd and host selection~~ to Onboarding, Settings screen and TOML config

2026-10-01 22:08:47 -05:00

deadstyle referenced this issue

2026-10-01 22:08:57 -05:00

UI shell: two-column navigation, repo list, boxes [1]-[3], details #8

deadstyle referenced this issue

2026-10-01 22:09:10 -05:00

docs: onboarding, Settings screen, TOML config (ADR 0004) #15

deadstyle referenced this issue

2026-10-02 11:44:22 -05:00

Product decisions needed for v1 #13

deadstyle referenced this issue

2026-10-02 12:01:03 -05:00

Onboarding, Settings screen and host picker #24

deadstyle changed title from ~~Onboarding, Settings screen and TOML config~~ to Config: TOML config and state, token resolution, host selection

2026-10-02 12:01:19 -05:00

deadstyle commented

2026-10-02 12:01:19 -05:00

🤖 Split: this ticket bundled the config layer with three screens (onboarding, Settings, host picker). The screens should follow the UI patterns #8 sets, so they moved to #24, which depends on #5 and #8. #5 is now the config layer only, and it can land before the UI exists.

deadstyle referenced this issue from a pull request that will close it,

2026-10-02 12:12:16 -05:00

feat(config): TOML config and state, token resolution, host selection #25

deadstyle referenced this issue from a commit

2026-10-02 12:12:16 -05:00

feat(config): load, validate and save config and state files

deadstyle referenced this issue from a commit

2026-10-02 12:12:16 -05:00

test(config): cover config, state, paths, host selection and token resolution

deadstyle referenced this issue from a commit

2026-10-02 12:12:16 -05:00

fix(config): bound token_cmd wait after kill, inline tomlEncode

deadstyle closed this issue

2026-10-02 12:13:32 -05:00

deadstyle commented

2026-10-02 12:13:32 -05:00

🤖 Merged in #25. Settings and remembered values are saved as TOML, the sign-in token comes from the command or a 0600 file, and the host is chosen by --host, then the only host, then default_host. The 'only merge when CI is green' setting is per host with a per-repo override, off by default. The screens are in #24.

Sign in to join this conversation.