deadstyle/lazyforge
Watch
1
0
Fork
You've already forked lazyforge
 0
Code Issues 1 Pull requests 2 Projects Releases 3 Packages Wiki Activity Actions

Fold plan-review findings into tickets and docs #17

New issue
Closed
opened 2026-10-01 22:22:37 -05:00 by deadstyle · 1 comment
deadstyle commented 2026-10-01 22:22:37 -05:00
Owner
Copy link

Problem

An external plan review (docs/plan-review.md) found gaps that must land in the tickets and docs before #4 freezes the interface. Opus has assessed it: findings 1–6 and the cleanup items are valid.

Plan

Fold each finding in where it belongs:

  • F1, multi-update Renovate PRs: our shared preset batches non-majors weekly per ecosystem, so multi-package PRs are the norm. Engineering: ChangeRequest.Renovate becomes a slice, and grouping keys include ecosystem and package identity → #2 (collect grouped PR bodies) and #4. Product: what a "group" means for batched PRs → question on #13.
  • F2, bulk merge contract: head-sha validation (Gitea merge head_commit_id), per-target results, reconcile before retry → #9 and #10. What the user sees after a partial failure → question on #13.
  • F3, typed resource refs for Comment/Close → #4.
  • F4, capability = adapter support + server version + repo permission, with disabled reasons → #4 and #6.
  • F5, host-wide scan: bounded concurrency, "scanned X of Y", incomplete coverage shown in confirmation → #7 and #10. Boundary (accessible vs member repos) → question on #13.
  • F6, v1 matrix: the ★ box [4] vs deferred [4]/[5] contradiction, R rerun, Actions fallback → question on #13.
  • Build order: make #8's goal one thin end-to-end slice (connect → repos → PR → confirm merge → result).
  • Cleanup: remove "not yet confirmed" from architecture.md Stack (ADR 0001); add failure recovery and package-manager detection to #12.

Each product question on #13 gets options with their user-visible consequence plus a recommendation.

Acceptance criteria

  • Every finding above is reflected in the named ticket bodies (plans in bodies, not comments)
  • #13 has the four new product questions, each with a recommendation
  • architecture.md Stack section corrected
  • The docs MR, including docs/plan-review.md, merged
## Problem An external plan review (`docs/plan-review.md`) found gaps that must land in the tickets and docs before #4 freezes the interface. Opus has assessed it: findings 1–6 and the cleanup items are valid. ## Plan Fold each finding in where it belongs: - **F1, multi-update Renovate PRs:** our shared preset batches non-majors weekly per ecosystem, so multi-package PRs are the norm. Engineering: `ChangeRequest.Renovate` becomes a slice, and grouping keys include ecosystem and package identity → #2 (collect grouped PR bodies) and #4. Product: what a "group" means for batched PRs → question on #13. - **F2, bulk merge contract:** head-sha validation (Gitea merge `head_commit_id`), per-target results, reconcile before retry → #9 and #10. What the user sees after a partial failure → question on #13. - **F3, typed resource refs for Comment/Close** → #4. - **F4, capability = adapter support + server version + repo permission, with disabled reasons** → #4 and #6. - **F5, host-wide scan:** bounded concurrency, "scanned X of Y", incomplete coverage shown in confirmation → #7 and #10. Boundary (accessible vs member repos) → question on #13. - **F6, v1 matrix:** the ★ box [4] vs deferred [4]/[5] contradiction, `R` rerun, Actions fallback → question on #13. - **Build order:** make #8's goal one thin end-to-end slice (connect → repos → PR → confirm merge → result). - **Cleanup:** remove "not yet confirmed" from architecture.md Stack (ADR 0001); add failure recovery and package-manager detection to #12. Each product question on #13 gets options with their user-visible consequence plus a recommendation. ## Acceptance criteria - [ ] Every finding above is reflected in the named ticket bodies (plans in bodies, not comments) - [ ] #13 has the four new product questions, each with a recommendation - [ ] architecture.md Stack section corrected - [ ] The docs MR, including `docs/plan-review.md`, merged
deadstyle commented 2026-10-02 10:29:48 -05:00
Author
Owner
Copy link

🤖 Ticket bodies updated (#2, #4, #6, #7, #8, #9, #10, #12) and four new product questions on #13 (9–12). Doc edits committed on docs/plan-review (78eb9cb) but not pushed yet: SSH on :2222 is timing out at the banner exchange. Will push and merge #18 once it's back.

🤖 Ticket bodies updated (#2, #4, #6, #7, #8, #9, #10, #12) and four new product questions on #13 (9–12). Doc edits committed on `docs/plan-review` (78eb9cb) but not pushed yet: SSH on :2222 is timing out at the banner exchange. Will push and merge #18 once it's back.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
renovate/go-non-major
renovate/ci-tools-non-major
main
chore/trim-agent-guides
feature/label-editing
feature/workshop-splash
claude/laughing-ritchie-hbzxsf
chore/renovate-patterns
v0.3.0
v0.2.0
v0.1.0
Labels
Clear labels   
bug
Something behaves wrong

  
docs
Documentation only

  
feature
New user-visible capability

  
maintenance
Dependency updates and upkeep (Renovate)

  
needs-pm
Parked: waiting on a product decision from the PM

  
opus
Driver: Opus drives it (complex, risky, or design-heavy)

  
sonnet
Driver: Sonnet can drive it (well-bounded, low risk)

  
spike
Time-boxed investigation that answers a question

  
tech-debt
Engineering cleanup with no user-visible change

No labels
bug
docs
feature
maintenance
needs-pm
opus
sonnet
spike
tech-debt
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
deadstyle/lazyforge#17
No description provided.