Show inline images on GitLab #143

New issue

deadstyle · 2026-10-12T07:51:40-05:00

deadstyle commented

2026-10-12 07:51:40 -05:00

Problem

Images in GitLab MR and issue bodies stay links, because the adapter has no AssetReader. Parent: #137. Depends on #138.

Acceptance criteria

A GitLab upload that stands alone in a paragraph of an MR or issue body draws inline in the Details pane, as on Forgejo, on public and private projects (design.md → Images).
An image that fails to load, or is on another host, stays the 🖼 alt link (design.md → Images).
The token is never sent off the GitLab host.

Plan

Body links are /uploads/<secret>/<file> relative to the project's web URL (or /-/project/<id>/uploads/<secret>/<file>). Web routes likely don't accept a token, so OpenAsset rewrites a same-origin upload URL to GET /api/v4/projects/:id/uploads/:secret/:filename (GitLab 17.4+, Guest and above) and streams it with the token, dropping it on any hop off the origin, as ADR 0017 does for GitHub. A URL that isn't an upload is fetched as-is. Older servers return 404 → the link stays.
Check first how relative upload links are resolved before they reach OpenAsset (ADR 0016), since GitLab's are relative to the project, not the host root.
Record the decision in ADR 0016 or 0018; update architecture.md.

Context

Precedents: internal/forge/github/assets.go, #87, ADR 0016. docs.gitlab.com → Project markdown uploads API.

## Problem Images in GitLab MR and issue bodies stay links, because the adapter has no `AssetReader`. Parent: #137. **Depends on #138.** ## Acceptance criteria - A GitLab upload that stands alone in a paragraph of an MR or issue body draws inline in the Details pane, as on Forgejo, on public and private projects *(design.md → Images)*. - An image that fails to load, or is on another host, stays the `🖼 alt` link *(design.md → Images)*. - The token is never sent off the GitLab host. ## Plan - Body links are `/uploads/<secret>/<file>` relative to the project's web URL (or `/-/project/<id>/uploads/<secret>/<file>`). Web routes likely don't accept a token, so `OpenAsset` rewrites a same-origin upload URL to `GET /api/v4/projects/:id/uploads/:secret/:filename` (GitLab 17.4+, Guest and above) and streams it with the token, dropping it on any hop off the origin, as ADR 0017 does for GitHub. A URL that isn't an upload is fetched as-is. Older servers return 404 → the link stays. - Check first how relative upload links are resolved before they reach `OpenAsset` (ADR 0016), since GitLab's are relative to the project, not the host root. - Record the decision in ADR 0016 or 0018; update architecture.md. ## Context - Precedents: `internal/forge/github/assets.go`, #87, ADR 0016. docs.gitlab.com → Project markdown uploads API.

deadstyle referenced this issue

2026-10-12 07:51:59 -05:00

Add a GitLab adapter #137

deadstyle referenced this issue

2026-10-12 07:52:00 -05:00

GitLab adapter: client and core Forge methods #138

deadstyle added the

feature

opus

labels

2026-10-12 07:52:00 -05:00

deadstyle commented

2026-10-12 08:51:19 -05:00

🤖 Planned through composer-lite (plan in the run; summary: an I/O-free asset resolver so GitLab's project-relative /uploads/ links resolve to the right project, OpenAsset through the uploads API, and a client-wide guard so the token never follows a redirect off the GitLab host). Starts once #139 merges.

🤖 Planned through composer-lite (plan in the run; summary: an I/O-free asset resolver so GitLab's project-relative `/uploads/` links resolve to the right project, `OpenAsset` through the uploads API, and a client-wide guard so the token never follows a redirect off the GitLab host). Starts once #139 merges.

deadstyle referenced this issue

2026-10-12 09:19:32 -05:00

feat(forge): GitLab pipelines, jobs, job logs and labels #148

deadstyle referenced this issue

2026-10-12 09:38:30 -05:00

feat(forge): show inline images on GitLab #149

deadstyle referenced this issue from a commit

2026-10-12 09:38:30 -05:00

fix(forge): keep the GitLab token on the GitLab host for every call

deadstyle referenced this issue from a commit

2026-10-12 09:38:30 -05:00

feat(forge): GitLab images through the uploads API