deadstyle/claude-marketplace
Watch
1
0
Fork
You've already forked claude-marketplace
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

review-army: review a feature's files, selectable lenses, observability/tech-debt/security lenses #1

New issue
Closed
opened 2026-07-24 06:24:49 -05:00 by deadstyle · 0 comments
deadstyle commented 2026-07-24 06:24:49 -05:00
Owner
Copy link

Problem

/labs:review-army already covers most of the "integrated feature review" pattern that was run by hand against the Kirria Slack integration: parallel read-only reviewers, one per lens, a shared brief, file:line + severity findings, and a de-duped, ranked report. It falls short of that pattern in three ways:

  1. Diff-only scope. It reviews the current branch against its merge-base. A completed, already-merged feature can't be reviewed: the target should be able to be a file or path set (the on-disk state), not just a diff.
  2. Fixed lens set. The five axes are hard-coded. The hand-run review added a lens mid-run; lenses should be selectable per run.
  3. Missing lenses:
    • Observability: can on-call tell it's healthy and diagnose it? Metrics, logging, failure-mode coverage. (Sonnet was enough here.)
    • Tech debt: accumulated shortcuts, TODO / ponytail: markers, stale comments, deprecated patterns, deferred work, drift between code and its docs/wiki.
    • Security as its own lens: authn/authz, tenant isolation, injection, secret handling, signature/replay verification, input validation at trust boundaries, dependency risk. Today it's only partial, via security-review inside the quality reviewer.

Scope

  • review-army accepts either a diff (default, unchanged) or a file/path set as its target. Every reviewer works from the same shared brief: target, working directory, architecture pointers, output format.
  • Lenses are selectable per run; the default set stays fixed so runs stay comparable.
  • New reviewer agents for observability, tech debt and security.
  • Synthesis is unchanged: merge overlap between lenses, rank, keep reviewer agreement visible.

No separate skill: this extends review-army rather than duplicating it.

## Problem `/labs:review-army` already covers most of the "integrated feature review" pattern that was run by hand against the Kirria Slack integration: parallel read-only reviewers, one per lens, a shared brief, file:line + severity findings, and a de-duped, ranked report. It falls short of that pattern in three ways: 1. **Diff-only scope.** It reviews the current branch against its merge-base. A completed, already-merged feature can't be reviewed: the target should be able to be a file or path set (the on-disk state), not just a diff. 2. **Fixed lens set.** The five axes are hard-coded. The hand-run review added a lens mid-run; lenses should be selectable per run. 3. **Missing lenses:** - **Observability**: can on-call tell it's healthy and diagnose it? Metrics, logging, failure-mode coverage. (Sonnet was enough here.) - **Tech debt**: accumulated shortcuts, TODO / `ponytail:` markers, stale comments, deprecated patterns, deferred work, drift between code and its docs/wiki. - **Security** as its own lens: authn/authz, tenant isolation, injection, secret handling, signature/replay verification, input validation at trust boundaries, dependency risk. Today it's only partial, via `security-review` inside the quality reviewer. ## Scope - review-army accepts either a diff (default, unchanged) or a file/path set as its target. Every reviewer works from the same shared brief: target, working directory, architecture pointers, output format. - Lenses are selectable per run; the default set stays fixed so runs stay comparable. - New reviewer agents for observability, tech debt and security. - Synthesis is unchanged: merge overlap between lenses, rank, keep reviewer agreement visible. No separate skill: this extends review-army rather than duplicating it.
deadstyle changed title from Add a labs skill for multi-agent integrated feature review to review-army: review a feature's files, selectable lenses, observability/tech-debt/security lenses 2026-10-04 09:58:18 -05:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/labs-parity
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
deadstyle/claude-marketplace#1
No description provided.